Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render vector tile vectors in correct sequence for the postrender event #13939

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Aug 5, 2022

Fixes #13938

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

📦 Preview the examples and docs from this branch here: https://deploy-preview-13939--ol-site.netlify.app/.

@ahocevar
Copy link
Member Author

ahocevar commented Aug 5, 2022

I now added a test to ensure the correct behavior. Without the fix, the sequence of context calls and events is

[
  'prerender', 'clearRect', 'postrender',
  'save', 'beginPath', 'moveTo',  'lineTo', 'lineTo', 'lineTo', 'clip', 'restore'
] 

With the fix, postrender comes last, as expected.

@ahocevar ahocevar merged commit a3bbd60 into openlayers:main Aug 5, 2022
@ahocevar ahocevar deleted the vectortile-postrender branch August 5, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VectorTileLayer render mode vector is rendered after the postrender event
2 participants