Do not apply #12467 change to Icons #13955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13955--ol-site.netlify.app/. |
ahocevar
reviewed
Aug 8, 2022
src/ol/render/canvas/Immediate.js
Outdated
| pixelRatio * imageScale[0], | ||
| pixelRatio * imageScale[1], | ||
| ]; | ||
| pixelRatio = 1; |
There was a problem hiding this comment.
Not sure if this is the correct fix. It would be batter if icons would be created with the pixel ratio of the destination context, then they would also appear crisper on high dpi devices.
There was a problem hiding this comment.
Yes, images with color applied are available at higher dpi. The ImageBuilder uses the image style's getPixelRatio() method to determine what is available, so that can also be used here.
There was a problem hiding this comment.
Updated to use high dpi images where available.
Use getPixelRatio() as in ImageBuilder
mike-000
force-pushed
the
immediate-icons
branch
from
4e7e397
to
8bbeb31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13954
Also fixed the rendering test which might have picked this up, but was not using the correct pixel ratio.
Compare the fixed version https://deploy-preview-13955--ol-site.netlify.app/examples/icon-scale.html
with https://openlayers.org/en/v6.15.1/examples/icon-scale.html
on a mobile device or with browser zoom