Updates for ol-mapbox-style v9.2 #14086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14086--ol-site.netlify.app/. |
tschaub
approved these changes
Sep 1, 2022
tschaub
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Actually, it looks like there might be an unwanted rendering issue introduced by this.
From this branch:
From the latest release:
Not sure which is right.
|
Ok, thanks for spotting this, @tschaub. I'm going to investigate this. |
|
Actually this branch fixes the appearance of the land areas. See openlayers/ol-mapbox-style#671. The latest release suffered from a problem with the changed background rendering. For comparison, see https://openlayers.org/en/v6.15.1/examples/mapbox-style.html. |
tschaub
approved these changes
Sep 1, 2022
|
I see. Thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the tests for background, because the underlying implementation in ol-mapbox-style has changed.