Add support for images in data tiles #14258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so data tiles can contain image data in addition to array data.
Adding support for images in data tiles makes sense as part of a larger plan to render all raster tiles with the WebGL tile renderer. The plan could look something like this:
ImageTile
(or similarly named) source that extends theDataTile
source. This would take aurl
option that would be a convenience for constructing aloader
. Theurl
could bestring|Array<string>|function(number, number, number):string
(the function form would return a url given z, x, and y tile coordinates. Deprecate the (canvas) tile layer, theTileImage
source, and lots of other things.WebGLTile
layer toTile
and remove all the deprecated things. TheDataTile
things could be renamed toRasterTile
(soRasterTile
andVectorTile
would be the two tile classes in the API).