Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure change:position event is fired if identify transform used #14319

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

mike-000
Copy link
Contributor

Fixes #14317

slice() the projected position coordinates array to ensure a change event is triggered as an identity transform, either from an undefined projection or one without transforms, will return this.position_ which will be the same array despite having changed contents.

@github-actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-14319--ol-site.netlify.app/.

Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks and please merge.

@ahocevar ahocevar merged commit ae0f176 into openlayers:main Nov 19, 2022
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000

@mike-000 mike-000 deleted the geolocation-identity branch November 22, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geolocation do not trigger event change:position if projection setting is omitted
3 participants