Remove pointer events polyfill from examples #14816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14816--ol-site.netlify.app/. |
|
I presume you did not intend to add the Circle example via this PR? |
ahocevar
force-pushed
the
remove-pointer-events-polyfill-from-examples
branch
from
1b76a8b
to
cc2b33e
Compare
|
Thanks, @mike-000. This was indeed unintentional. |
jahow
approved these changes
Jun 17, 2023
There was a problem hiding this comment.
Looks like Safari was the last to add support and that was 4 years ago so, makes sense!
By the way elm-pep is mentioned here:
openlayers/src/ol/MapBrowserEventHandler.js
Lines 362 to 363 in b80fc19
I guess it doesn't hurt to keep this workaround but maybe rephrasing the comment would make sense since elm-pep is not used anymore in the examples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's now been long enough to wait for browsers without pointer events support to disappear.