-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGL / Rework symbol rendering to include circles with outlines, shapes and icons #14883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
force-pushed
the
webgl-symbol-outline
branch
from
July 6, 2023 09:59
ece4332
to
16fc7dd
Compare
📦 Preview the website for this branch here: https://deploy-preview-14883--ol-site.netlify.app/. |
jahow
force-pushed
the
webgl-symbol-outline
branch
6 times, most recently
from
July 12, 2023 07:31
196c6cf
to
1da1568
Compare
This is ready for review, please let me know if I need to subdivide some commits further to make this easier to read, thanks in advance! |
tschaub
approved these changes
Aug 12, 2023
@jahow - this looks great! I meant to review it earlier, but then lost track of it. |
tschaub
reviewed
Aug 12, 2023
This allows not writing explicit shaders which are then harder to maintain
jahow
force-pushed
the
webgl-symbol-outline
branch
from
August 14, 2023 08:03
f3f5ce2
to
fb6d489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly reworks how symbols are handled in the WebGL renderers. Symbol styles now use a format that is compatible with the "flat" style format used by Canvas renderers, and which looks like this:
The previous symbol style format is not supported anymore: using it will simply not show anything on screen.
New styling possibilities include:
Image
, with displacement, offset, anchor etc.Note: this will break existing applications using
WebGLPointsLayer
with the previous style format. I figured that since we're moving towards a new major version, it was the right time to introduce a breaking change (which only affects parts of the API marked as experimental anyway).I added several rendering tests to better guarantee the output of the rendering in WebGL.
Remaining to do:
This work is sponsored by BSW-Hamburg and Landesbetrieb Geoinformation und Vermessung Hamburg.