Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #14968 #14972

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix #14968 #14972

merged 1 commit into from
Aug 3, 2023

Conversation

tanhh326
Copy link
Contributor

@tanhh326 tanhh326 commented Aug 3, 2023

fix #14968

In the debugging process, I also found a lot of methods missed @Api annotations, resulting in the documentation is not rendered, wait for the follow-up and then unified change it, right?

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

📦 Preview the website for this branch here: https://deploy-preview-14972--ol-site.netlify.app/.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tanhh326

@ahocevar ahocevar merged commit 95b0571 into openlayers:main Aug 3, 2023
@ahocevar
Copy link
Member

ahocevar commented Aug 3, 2023

@tanhh326 If something is not marked @api, it is not meant to be part of the API at all, or experimental. Which symbols are you referring to?

@tanhh326
Copy link
Contributor Author

tanhh326 commented Aug 4, 2023

There are quite a few of them in this tool class. @ahocevar

export function equals(coordinate1, coordinate2) {

@ahocevar
Copy link
Member

ahocevar commented Aug 4, 2023

Yes. like I said, those are intentionally not part of the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: BaseVector.getFeatures shows incorrect return value
2 participants