Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates #14999

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Doc updates #14999

merged 2 commits into from
Aug 12, 2023

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Aug 11, 2023

Currently, comments with @fileoverview (or @file) get ignored (they end up undocumented: true due to the api plugin). If a comment with @fileoverview is given an @api tag, the comment is included inline in the index page (we concatenate all file type tags with the index docs).

Since we don't currently use the @fileoverview and @api tag combo anywhere, I repurposed this to serve as a way to add a description for a module.

In this branch, I've also updated the templates so the table for typedefs looks more like the table for constructor options.

I've updated the docs for the ol/style/flat.js module to demonstrate the change. Here is an animation of the before/after change (after has the module description, example, and typedef table changes).

doc-change

@github-actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-14999--ol-site.netlify.app/.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thanks!

@tschaub tschaub merged commit 1168b96 into openlayers:main Aug 12, 2023
@tschaub tschaub deleted the doc-updates branch August 12, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants