-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OL STAC example #15042
Add OL STAC example #15042
Conversation
23e484d
to
b076383
Compare
b076383
to
f035d1d
Compare
📦 Preview the website for this branch here: https://deploy-preview-15042--ol-site.netlify.app/. |
Usually the region between the original image extent and the extent which encloses it when reprojected is transparent, as in https://codesandbox.io/s/multiple-cogs-forked-8ls754?file=/main.js, not black as here
|
e3600fa
to
866dd8d
Compare
Good point, OL STAC tried to default to NaN if no nodata value was provided through STAC, but that was obviously not a good idea as it discarded any nodata values from the TIFF. Fixed. |
Yes, I have sometimes found it necessary to add a nodata setting to force an alpha band to be added for non-parallel reprojection, but doing that unnecessarily overrides any genuine nodata. It might be better if any supplied setting was appended instead of simply overriding. |
#15048 will ensure alpha can be set in regions outside the original source extent without overriding the metadata. The metadata would handle alpha inside the original extent. |
6276595
to
9c883cb
Compare
Co-authored-by: Tim Schaub <tschaub@users.noreply.github.com>
9c883cb
to
3541be2
Compare
Updated and re-released ol-stac with ol as peer dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @m-mohr
Adds an OL STAC example as requested in #14927
It does complain about missing dependencies. Do I need to add it do devDependencies? Edit: Yes, that seems to work. Hope that's the right way of doing it.