Create new loader if view projection changes #15165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15165--ol-site.netlify.app/. |
mike-000
force-pushed
the
projection-change
branch
from
c0ce56f
to
52a68c1
Compare
ahocevar
requested changes
Sep 22, 2023
| @@ -141,8 +147,9 @@ class ImageArcGISRest extends ImageSource { | |||
| if (this.url_ === undefined) { | |||
| return null; | |||
| } | |||
| if (!this.loader) { | |||
| if (!this.loader || this.loaderProjection_ !== projection) { | |||
There was a problem hiding this comment.
The equivalent() function should be used here
There was a problem hiding this comment.
The code replicates the behavior before version 8 - if the view projection was EPSG:3857 the image was requested for CRS EPSG:3857, if the view projection was changed to EPSG:900913 the image was requested for CRS EPSG:900913. Ditto for EPSG:4326/CRS:84, etc.
| @@ -141,8 +147,9 @@ class ImageMapGuide extends ImageSource { | |||
| if (this.url_ === undefined) { | |||
| return null; | |||
| } | |||
| if (!this.loader) { | |||
| if (!this.loader || this.loaderProjection_ !== projection) { | |||
| @@ -195,8 +201,9 @@ class ImageWMS extends ImageSource { | |||
| if (this.url_ === undefined) { | |||
| return null; | |||
| } | |||
| if (!this.loader) { | |||
| if (!this.loader || this.loaderProjection_ !== projection) { | |||
ahocevar
approved these changes
Sep 23, 2023
|
Obviously a test would be good to avoid future regressions on this. |
ahocevar
approved these changes
Sep 23, 2023
|
Thanks, @mike-000 |
|
Thanks you very much guys ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15161