Remove radius1 for regular shapes, use radius instead

[MoonE]

Having two optional parameters where one is required is bad for type-checking.

Current handling is inconsistent. RegularShape constructor treated radius and radius1 as aliases while the webgl style parser used radius exclusively for polygons and radius1 exclusively for stars.

[github-actions]

📦 Preview the website for this branch here: https://deploy-preview-15191--ol-site.netlify.app/.

[jahow]

I really like this simplification, thanks! And as we are changing property names anyway, could we use something like radiusInner instead of radius2?

[jahow]

I think you should explicitly mark that as a breaking change

[MoonE]

Isn't the upgrade notes all about breaking changes? I don't see any previous changes marked explicitly as breaking there.
What do you have in mind?

[jahow]

For version 8 the breaking changes were put in separate section: https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md#backwards-incompatible-changes

This is what I had in mind

[MoonE]

For RegularShape there is no requirement for radius to be larger than radius2. So calling it inner / outer doesn't make sense there.
For webgl this unfortunately doesn't hold true, but if this is improved upon in the future it would be a misnomer.
See https://openlayers.org/en/latest/examples/webgl-points-layer.html with a style like:

{
  "shape-points": 5,
  "shape-radius1": ["+", ["*", ["sin", ["time"]], 10], 20],
  "shape-radius2": ["+", ["*", ["sin", ["time"]], -10], 20],
  "shape-rotation": ["*", ["time"], 0.2],
  "shape-fill-color": "red",
  "shape-stroke-color": "black",
  "shape-stroke-width": 2
}

[MoonE]

I added a commit that allows radius2 to be larger than radius for webgl rendering.

[jahow]

For RegularShape there is no requirement for radius to be larger than radius2. So calling it inner / outer doesn't make sense there. For webgl this unfortunately doesn't hold true, but if this is improved upon in the future it would be a misnomer

Thanks, you're totally right!

[jahow]

Thanks for the simplification and fixing the webgl style parser in the process! I'm not sure when would be the best time for merging this though, but still, at least this is approved.