Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename protected properties, mark properties as private #15972

Merged
merged 6 commits into from
Jul 7, 2024
Merged

Rename protected properties, mark properties as private #15972

merged 6 commits into from
Jul 7, 2024

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Jul 6, 2024

No description provided.

@MoonE
Copy link
Contributor Author

MoonE commented Jul 6, 2024

@tschaub @ahocevar The deploy preview seems to no longer work on any new pull requests.

@ahocevar
Copy link
Member

ahocevar commented Jul 7, 2024

@tschaub @ahocevar The deploy preview seems to no longer work on any new pull requests.

@MoonE I created #15973, which should fix this. If you could review that, I'll merge and we will see.

ahocevar
ahocevar approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MoonE

@MoonE MoonE changed the title Rename protected propertys, mark property as private Rename protected properties, mark properties as private Jul 7, 2024
@MoonE MoonE merged commit a5e34f6 into openlayers:main Jul 7, 2024
8 checks passed
@MoonE MoonE deleted the private-properties branch July 7, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoonE @ahocevar