Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type generics for VectorImageLayer #16348

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix type generics for VectorImageLayer #16348

merged 1 commit into from
Nov 6, 2024

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Nov 6, 2024

Fixes #16347

@ahocevar ahocevar mentioned this pull request Nov 6, 2024
Closed
@ahocevar ahocevar merged commit 92e64df into openlayers:main Nov 6, 2024
8 checks passed
@ahocevar ahocevar deleted the vectorimagelayer-types branch November 6, 2024 17:51
@bad-ch
Copy link

bad-ch commented Nov 11, 2024 •
edited
Loading

Hi, I think that will not fix the issue, that last working version for me was 9.2.0, every release afterwards 9.2.1 - 10.2.1 has this problem, which I has described in the issue #16347. At least the replacement of the files has not helped

@ahocevar
Copy link
Member Author

ahocevar commented Nov 11, 2024 •
edited
Loading

@bad-ch Try with npm install ol@dev. Replacing the source file will not help, because the .d.ts files used for the types are generated in a build step.

@bad-ch
Copy link

bad-ch commented Nov 11, 2024

Agree sorry, after installing the dev version it solves the problem, so many thank's to you :o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaub tschaub tschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VectorImage type declaration errors
3 participants
@ahocevar @bad-ch @tschaub