KML options not applied when library built separately from application #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for finding this @ahocevar LGTM please merge when Travis is happy |
ahocevar
added a commit
that referenced
this pull request
May 16, 2013
KML options not applied when library built separately from application. r=@bartvde
|
follow-up ticket for GML is here: #714 |
yinxiaomei
pushed a commit
to yinxiaomei/ol3
that referenced
this pull request
Nov 19, 2013
This is a follow-up for openlayers/openlayers#711 for the GML parser. Also use goog.array.map instead of map as was pointed out by @twpayne on the WKT review and update the example data to use all US states as pointed out by @tschaub on the Google hangout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this is that the constructor applies the options to the instance. This should not be done.
The same will need to be fixed for the GML parser - @bartvde will be working on that.