Allow changing parameters/dimensions for WMS and WMTS

[elemoine]

This PR allows to dynamically change parameters and dimensions of WMS and WMTS sources. This is a collaborative work with @oterral and @twpayne.

Commit 7779ca6, which adds getDimensions and updateDimensions ol.source.WMTS, is a also a refactoring of the ol.source.WMTS code.

[bbinet]

I'm wondering if the same cache key could be generated for different params (which would have the same value) if we only include the params values (not the keys) to build the cache key?

[twpayne]

The computation of goog.object.getValues(this.params_).join('/') can also be done and cached when this.params_ changes. This'll save some time and garbage.

[elemoine]

Thanks for the comments @bbinet and @twpayne. Does 4c708ba work for you?

[twpayne]

4c708ba looks good.

[bbinet]

It looks very good, thanks Eric.

On 9 September 2013 14:26, Éric Lemoine notifications@github.com wrote:

Thanks for the comments @bbinet https://github.com/bbinet and @twpaynehttps://github.com/twpayne.
Does 4c708ba 4c708ba work for
you?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/994#issuecomment-24068992
.

[probins]

Wouldn't setParams be more consistent naming?

[bbinet]

setParams would suggest that it replace the whole params object, but it is not the case here.

[elemoine]

Wouldn't setParams be more consistent naming?

User/custom params are known as dimensions in WMTS. And with WMTS REST dimensions are not sent as GET parameters. Dimension is a more general term that applies to both REST and KVP.

[elemoine]

If we had setParams instead of updateParams the user would have to do something like this to add or update parameters:

source.setParams($.extend({}, this.getParams(), {foo: 'foo', bar: 'bar}));

(This assumes jQuery.)

We've considered that updateParams makes a more convenient API.

I'm going to merge this but I'm happy to re-discuss the API, and change it if people think that a getParams/setParams, or something, would be better.