Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring labels #5

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Refactoring labels #5

merged 2 commits into from
Jul 21, 2024

Conversation

nlamirault
Copy link
Contributor

  • Support all Kubernetes recommended labels
  • Support for additional labels

@nlamirault
Refactoring labels
03696c7 
- Support all Kubernetes recommended labels
- Support for additional labels

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault nlamirault requested a review from a team as a code owner July 19, 2024 07:59
@nlamirault nlamirault requested review from patcher9 and removed request for a team July 19, 2024 07:59
patcher9

This comment was marked as duplicate.

Sign in to view

patcher9
patcher9 reviewed Jul 21, 2024
View reviewed changes
Copy link
Contributor

@patcher9 patcher9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just one small addition

charts/openlit/Chart.yaml Outdated Show resolved Hide resolved
@patcher9 patcher9 merged commit f72342c into openlit:main Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patcher9 patcher9 patcher9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlamirault @patcher9