Sync OpenMage #44
Merged
Sync OpenMage #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.62.0 to 3.64.0. - [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases) - [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md) - [Commits](PHP-CS-Fixer/PHP-CS-Fixer@v3.62.0...v3.64.0) --- updated-dependencies: - dependency-name: friendsofphp/php-cs-fixer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Convert double-quotes to single-quotes
…talog_Model_Product_Attribute_Backend_Media (#4136) * fix issues 4134 * better code Co-authored-by: kiatng --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Fixes some phpstan errors * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Update app/code/core/Mage/Tag/Model/Tag.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * Updated docblock - have to keep array from parent method --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * DocBlock update * Update app/code/core/Mage/Adminhtml/Helper/Help/Mapping.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * Update app/code/core/Mage/Core/Model/Session/Abstract.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * Update app/code/core/Mage/Core/Model/Session/Abstract.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
* Bump phpstan/phpstan from 1.11.7 to 1.12.0 Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.11.7 to 1.12.0. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.12.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.11.7...1.12.0) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Phpstan: update for v1.12 (#4179) * patch 1.11 * patch 1.12 * patch 1.12 - ignore errors --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sven Reichel <github-sr@hotmail.com>
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 44 to 45. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v44...v45) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions
bot
added
environment
Component: PayPal
* Bump phpstan to level 5 * Revert "Bump phpstan to level 5" This reverts commit 8b6f2f8. * Bump phpstan to level 5
* Bump phpstan/phpstan from 1.12.3 to 1.12.6 Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.12.3 to 1.12.6. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/2.0.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.12.3...1.12.6) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * phpstan 1.12.5 fixes (#4260) * phpstan-fixes * baseline * phpcbf * Updated .phpstan.dist.baseline.neon --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sven Reichel <github-sr@hotmail.com>
Bumps [rector/rector](https://github.com/rectorphp/rector) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@1.2.5...1.2.6) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sven Reichel <github-sr@hotmail.com>
* Added better caching for phpstan * Updated phpstan baseline
* Fixes 4217 * Button size
Bumps [rector/rector](https://github.com/rectorphp/rector) from 1.2.6 to 1.2.7. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@1.2.6...1.2.7) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* polyfill-8.3 * polyfill-8.3/8.4 * Updated .phpstan.dist.baseline.neon * Merge branch 'main' into ADDISON74-polifyll-8.3 # Conflicts: # composer.lock --------- Co-authored-by: Sven Reichel <github-sr@hotmail.com>
Bumps [macopedia/phpstan-magento1](https://github.com/macopedia/phpstan-magento1) from 1.0.7 to 1.0.8. - [Release notes](https://github.com/macopedia/phpstan-magento1/releases) - [Commits](macopedia/phpstan-magento1@v1.0.7...v1.0.8) --- updated-dependencies: - dependency-name: macopedia/phpstan-magento1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix + tests * Improvement * phpcs * Added helper method * Typo spaces * Updated warning message * Added test --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
* fixes mktime * fixes with return type void returns * fixes getRowUrl * phpstan * rector * minor fix
* fixes [wip] * fixes * fixes
* PHP8: base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated - #4243 (comment) * refactor * refactor * refactor * refactor [skip ci] * Update app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.12.6 to 1.12.7. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/2.0.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.12.6...1.12.7) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rector/rector](https://github.com/rectorphp/rector) from 1.2.7 to 1.2.8. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@1.2.7...1.2.8) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixes price filter * Fixes price filter (test) * copyright * Unified grid columns - makes all "entity_id" grid columns searchable "from" "to" - disallow/ignore non-numeric input on price/currency/range grid columns - removed useless "'sortable' => true" * Increased width * Unified "edit" column * Unified "action" column * Unified "store" column * Use config from XML * Added test * phpcs * Update tests/unit/Mage/Adminhtml/Block/Widget/GridTest.php Removed usseles line * typo * Unified "currency" column * Unified "price" column * Unified "currency" column * Unified "currency" column - added config helper * Unified "number" column - removed useless align right * updated copyright dates * cleanup * Removed "from" "to" label to safe space - add input placeholder * Typo [skip ci] * Re-added "from" "to" label to legacy theme * Flush cache once if an old config is cached * Hide placeholder in legacy theme * Update app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/Consumer/Grid.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * Update app/code/core/Mage/Adminhtml/Block/Widget/Grid.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
…efault value will change (#4297) * fgetcsv - lib/Varien/Convert/Parser/Csv.php Deprecated. The $escape parameter must be provided as its default value will change. * fgetcsv - app/code/core/Mage/ImportExport/Model/Import/Adapter/Csv.php Deprecated. The $escape parameter must be provided as its default value will change. * fgetcsv - lib/Varien/Io/File.php Deprecated. The $escape parameter must be provided as its default value will change. * fgetcsv - lib/Varien/File/Csv.php Deprecated. The $escape parameter must be provided as its default value will change. * fgetcsv - app/code/core/Mage/Dataflow/Model/Session/Parser/Csv.php Deprecated. The $escape parameter must be provided as its default value will change. * Missing variabile fEsc in function parseTest() * Missing $ in front of the variable * Revert the typo * escape parameter in function * PHP CS Fixer for lib/Varien/Io/File.php
…efault value will change (#4298) * fputcsv - lib/Varien/File/Csv.php Deprecated. The PHP default value for the escape parameter is '\\' and I declared it at the beginning in certain files. * fputcsv - lib/Magento/Profiler/Output/Csvfile.php Deprecated. Deprecated. The $escape parameter must be provided as its default value will change. * fputcsv - lib/Varien/Io/File.php Deprecated. The $escape parameter must be provided as its default value will change. * fputcsv - app/code/core/Mage/ImportExport/Model/Export/Adapter/Abstract.php Deprecated. The $escape parameter must be provided as its default value will change. * fputcsv - app/code/core/Mage/ImportExport/Model/Export/Adapter/Csv.php Deprecated. The $escape parameter must be provided as its default value will change. * Revert the changes * escape parameter in function Co-authored-by: Sven Reichel <github-sr@hotmail.com> * PHP CS Fixer - lib/Varien/Io/File.php --------- Co-authored-by: Sven Reichel <github-sr@hotmail.com>
* fix for php84 deprecated E_STRICT * baseline * Update app/code/core/Mage/Core/functions.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * baseline --------- Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.