Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to CBL0006 and CBL0007 #140

Merged

Conversation

klausmelcher
Copy link
Contributor

Since the Chapter 11.2.3 Conditional names isn't covered in the Labs, i changed the program in a way that the logic is different, but the task and results are the same. I also left the extra dot in the code, so you still have to search the error and correct it.

Signed-off-by: klausmelcher <klaus.melcher@gmail.com>
Signed-off-by: klausmelcher <klaus.melcher@gmail.com>
@jellypuno
Copy link
Contributor

@klausmelcher Thanks for adding this! Do you think the comments can be added in the *.md file?
@MikeBauerCA What do you think?

@klausmelcher
Copy link
Contributor Author

@klausmelcher Thanks for adding this! Do you think the comments can be added in the *.md file?
@MikeBauerCA What do you think?
@jellypuno
I don't know how to obtain the same Syntax highlighting colors as used in the images of the *.md file

@jellypuno
Copy link
Contributor

@jellypuno
I don't know how to obtain the same Syntax highlighting colors as used in the images of the *.md file

You can install COBOL Bitlang in your VSCode extension

Signed-off-by: klausmelcher <klaus.melcher@gmail.com>
@klausmelcher
Copy link
Contributor Author

klausmelcher commented Jun 20, 2020

@jellypuno I made an update to my pull request. Using COBOL Bitlang, I did not succeed in matching the colors exactly (commit 6ab9ba6). But with the HILITE AUTO command from Z/OS ISPF Editor, I got better results (commit 31f83ef).
If it is good enough, I can add further figures in my next pull request.

Signed-off-by: klausmelcher <klaus.melcher@gmail.com>
@MikeBauerCA
Copy link
Contributor

@klausmelcher I see you have added an image in this PR but do not reference it in the course. Where would you like to add the image?

@klausmelcher
Copy link
Contributor Author

@klausmelcher I see you have added an image in this PR but do not reference it in the course. Where would you like to add the image?

@MikeBauerCA The reference is in line 2895 of the COBOL Programming Course #1 - Getting Started.md file. I would like to replace the image which is already referenced with a new one with comments, as suggested by @jellypuno.

Copy link
Contributor

@MikeBauerCA MikeBauerCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MikeBauerCA MikeBauerCA merged commit 5b9c035 into openmainframeproject:master Jun 26, 2020
klausmelcher added a commit to klausmelcher/cobol-programming-course that referenced this pull request Jul 2, 2020
klausmelcher added a commit to klausmelcher/cobol-programming-course that referenced this pull request Jul 2, 2020
Sudharsana-Srinivasan added a commit that referenced this pull request Jul 7, 2020
Replacing images without comments, as suggested in Pull Request #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants