Rename CBL0033J to CBL0003J

[tanto259]

Signed-off-by: Hartanto Ario Widjaya tanto259@users.noreply.github.com

This would fix #198. It appears #153 is not merged into the mainframe system, thus resulting in confusion with the PDF content.

Personally, I would prefer that the new CBL0003.cbl be renamed to something else or adopt the CBL0033 naming (8af11a0) to prevent confusion with existing tutorials and PDF which are already on circulation (such as Coursera, Pluralsight and the IBM Learning Platform).

[MikeBauerCA]

Thanks for contributing @tanto259. If @paulnewt just added that CBL0033J (https://github.com/openmainframeproject/cobol-programming-course/blob/master/COBOL%20Programming%20Course%20%231%20-%20Getting%20Started/Labs/jcl/CBL0033J.jcl) member on the mainframe, would that resolve this issue? Tagging @klausmelcher who contributed #153 as well.

[tanto259]

Currently it will require Paul to edit CBL0003J and add CBL0003 & CBL0033J.

My concern right now is that since the Coursera and IBM Learning Platform's docs are often outdated, it will create discrepancy between the GitHub PDF and the docs, which may cause some confusion for everyone using the system.

Therefore, I would propose renaming CBL0003s that Klaus added as CBL0033 which would only require Paul to add CBL0033s and keep the old docs file as valid.

[MikeBauerCA]

Makes sense to me. We need to enable the system to support new content and old content simultaneously to accommodate all users. I'll wait for @paulnewt's comment before approving so he is aware of the needed update.

[paulnewt]

ZOS.PUBLIC.CBL member CBL0003 now exists. ZOS.PUBLIC.JCL member CBL0033J now exists. Member CBL0003J and CBL0033J compile newly added source CBL0003

[tanto259]

Thanks for the upload @paulnewt !

But I think there's some issues here:

1. Originally, before Contribution to Issue #112 #153, CBL0003J is a JCL which is intentionally designed to have a bug, in which it executes CBL0001 but with an incorrect DD name
2. Klaus then submitted Contribution to Issue #112 #153, in which he added a COBOL program which he called CBL0003 and the corresponding JCL CBL0003J, which is designed to explain subroutine calls. Since CBL0003J already existed previously, he renamed the old one (which is buggy) to CBL0033J.
3. However, this causes some issues since the Lab files on both Coursera and IBM Learning Platform still references the buggy JCL as CBL0003J instead of its new name, CBL0033J. Thus, in order to maintain compatibility with prior docs out there, I open this pull request.

Basically what this pull request did is bring back the renamed JCL to CBL0003J and changes Klaus' COBOL and JCL to adopt the CBL0033 naming. But the update basically removed the buggy JCL and put an exact copy of CBL0001 as CBL0003, so Klaus' code is still not on the system.

If you prefer, I can upload the codes over to ZOS.PUBLIC.ADHOC.CBL and ZOS.PUBLIC.ADHOC.JCL so you will only need to copy it over to production.

[MikeBauerCA]

@tanto259 @paulnewt the confusion comes from CBL0003J.jcl executing CBL0001.cobol and CBL0033J.jcl executing CBL0003.cobol. We don't want to change the former because of backwards compatibility on existing tutorials in circulation that are somewhat out of date. But we can change the latter without much impact.

Going forward we should avoid renaming existing programs for backwards compatibility reasons.

@tanto259 can you review what is on the system and work with @paulnewt if an update is needed. The PR looks good to merge once we verify the system matches.

To summarize:
CBL0003J compiles CBL0001
CBL0033J compiles CBL0033
CBL0003 should not exist to avoid confusion

[tanto259]

Sure. @paulnewt, here are the changes needed to the system:

• delete CBL0003 in ZOS.PUBLIC.CBL
• move CBL0033 from ZOS.PUBLIC.ADHOC.CBL to ZOS.PUBLIC.CBL
• move CBL0003J and CBL0033J from ZOS.PUBLIC.ADHOC.JCL to ZOS.PUBLIC.JCL and overwrite the old one there

Those should correspond to the changes made in this pull request. At the end of the day, CBL0003.cbl should no longer exist on the system.

[tanto259]

@MikeBauerCA I have talked to Paul, and he has merged the required changes to the system.

ZOS.PUBLIC.CBL(CBL0033) now exists, CBL0003 is no longer there, and ZOS.PUBLIC.JCL(CBL0003J and CBL0033J) updated.

[MikeBauerCA]

@tanto259 thanks, if you can resolve the merge conflicts in this PR, I will accept and merge.

[tanto259]

Noted, the merge conflict should be resolved already. Thanks @MikeBauerCA