-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Explanation about Dynamic-Length Items and UTF-8 Data #215
Merged
MikeBauerCA
merged 5 commits into
openmainframeproject:master
from
tanto259:dynamic-with-utf-8
May 3, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c2d52fe
Add Dynamic Length Items
tanto259 845719e
Add UTF-8 Data Items
tanto259 60d7461
Edit paragraphs on dynamic-length
tanto259 c81c78a
Add additional information section with links to manuals to Course 2
tanto259 b10afde
Merge branch 'master' into dynamic-with-utf-8
MikeBauerCA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned in the PR, much of this content is from the Enterprise COBOL for z/OS documentation - https://www.ibm.com/docs/en/cobol-zos/6.3?topic=relationships-dynamic-length-items. Let's credit this source up-front. Additionally, much of this content is identical to that source. We should either quote the source directly or construct this chapter in our own words from what we learned from the source (and still credit it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Would something like the Professional Manuals section on Course 1 suffice? Since I recall someone said that Course 1 was adapted from the Programming Guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of including something like the Professional Manuals section of Course 1 in Course 2. I still believe that when we adapt content, we should use our own words or directly quote the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Will re-write the paragraphs on this PR sometimes this week. Additionally, I will also put the Professional Manuals section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to c81c78a. When Course 2 is finalized, might need to shift things around to tidy the placing and formatting of the Professional Manuals section.