-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split course 1 into course 1 and course 2 #272
Split course 1 into course 1 and course 2 #272
Conversation
@tanto259 Please review the following pull request for changes suggested to course 1. I have updated all the necessary files for the same. |
Hi Sainath, Thanks for the PR! I just talked a bit with the rest of the TSC members, and we may need some additional updates to this PR. A couple of points:
While this may results in confusion, we will also release a new major version of the course by the conclusion of this mentorship period (i.e. 3.0.0), detailing the changes made. There are also several comments on the changes itself. Again, thank you for submitting this! |
COBOL Programming Course #0 - Getting Started/COBOL Programming Course #0 - Getting Started.md
Outdated
Show resolved
Hide resolved
COBOL Programming Course #0 - Getting Started/COBOL Programming Course #0 - Getting Started.md
Outdated
Show resolved
Hide resolved
COBOL Programming Course #0 - Getting Started/COBOL Programming Course #0 - Getting Started.md
Outdated
Show resolved
Hide resolved
COBOL Programming Course #0 - Getting Started/COBOL Programming Course #0 - Getting Started.md
Outdated
Show resolved
Hide resolved
COBOL Programming Course #1 - Learning COBOL/COBOL Programming Course #1 - Learning COBOL.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub seems to be weird for me in that the Files changed section for all commits seems to not be correct.... (i.e. For Course 1, the Images folder are in another Images folder and the Front_Matter and README is not there)
But the source branch, and the files changed for individual commits are correct.
In any case, besides the 4 comments, it seems that the README on the Labs folder for Course 2 and Course 3 still reference the wrong course number.
Thanks for the changes, Sainath!
COBOL Programming Course #1 - Getting Started/COBOL Programming Course #1 - Getting Started.md
Outdated
Show resolved
Hide resolved
COBOL Programming Course #2 - Learning COBOL/COBOL Programming Course #2 - Learning COBOL.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried generating the PDF, besides the comments are all good. Let's get this merged after we have Zowe updated with the team configuration for the first lab here :)
COBOL Programming Course #2 - Learning COBOL/COBOL Programming Course #2 - Learning COBOL.md
Show resolved
Hide resolved
COBOL Programming Course #2 - Learning COBOL/COBOL Programming Course #2 - Learning COBOL.md
Show resolved
Hide resolved
COBOL Programming Course #2 - Learning COBOL/COBOL Programming Course #2 - Learning COBOL.md
Show resolved
Hide resolved
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Proposed changes
Divide Course 1 into Course 0 and Course 1
Type of change
Checklist: