Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split course 1 into course 1 and course 2 #272

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

pathange-s
Copy link
Contributor

Proposed changes

Divide Course 1 into Course 0 and Course 1

Type of change

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

@pathange-s
Copy link
Contributor Author

@tanto259 Please review the following pull request for changes suggested to course 1. I have updated all the necessary files for the same.

@tanto259 tanto259 added the documentation Improvements or additions to documentation label Jul 15, 2022
@tanto259
Copy link
Member

Hi Sainath,

Thanks for the PR! I just talked a bit with the rest of the TSC members, and we may need some additional updates to this PR.

A couple of points:

  • So we are changing the numbering back. Course 0 will be Course 1, Course 1 will be Course 2 and so on.
  • In particular, Course 1 will only be a Course Setup course - so this will be the part detailing the toolings being used and how to use them.
  • Course 2 will be the Learning COBOL, Course 3 will be the Advanced Topics and Course 4 will be Testing.

While this may results in confusion, we will also release a new major version of the course by the conclusion of this mentorship period (i.e. 3.0.0), detailing the changes made.

There are also several comments on the changes itself.

Again, thank you for submitting this!

@pathange-s pathange-s changed the title Split course 1 into course 0 and course 1 Split course 1 into course 1 and course 2 Jul 15, 2022
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub seems to be weird for me in that the Files changed section for all commits seems to not be correct.... (i.e. For Course 1, the Images folder are in another Images folder and the Front_Matter and README is not there)

But the source branch, and the files changed for individual commits are correct.

In any case, besides the 4 comments, it seems that the README on the Labs folder for Course 2 and Course 3 still reference the wrong course number.

Thanks for the changes, Sainath!

Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried generating the PDF, besides the comments are all good. Let's get this merged after we have Zowe updated with the team configuration for the first lab here :)

Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
Signed-off-by: pathange-s <sainatharao@gmail.com>
@tanto259 tanto259 merged commit b76ce00 into openmainframeproject:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants