Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve COBOL snippets in doc, and improve code readability in COBOL sources #279

Merged
merged 17 commits into from
Oct 19, 2022

Conversation

vargajb
Copy link
Contributor

@vargajb vargajb commented Oct 18, 2022

Proposed changes

Fix syntax errors in COBOL snippets in doc

  • "WORKING-STORAGE." -> "WORKING-STORAGE SECTION."
  • "WORKING-STORAGE SECTION" -> "WORKING-STORAGE SECTION."
  • "PROCEDURE DIVISION" -> "PROCEDURE DIVISION."

Improve loop readability in COBOL programs and in COBOL snippets in doc

  • Old
PERFORM UNTIL LASTREC = 'Y'
PERFORM WRITE-RECORD
PERFORM READ-RECORD
END-PERFORM
.....
READ ACCT-REC
AT END MOVE 'Y' TO LASTREC
END-READ.
  • Improved
PERFORM UNTIL LASTREC = 'Y'
    PERFORM WRITE-RECORD
    PERFORM READ-RECORD
END-PERFORM
.....
READ ACCT-REC
    AT END MOVE 'Y' TO LASTREC
END-READ.

Fixes # (issue)

Type of change

What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

Fix syntax errors in COBOL snippets
Improve loop readability in COBOL snippets

Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
@tanto259 tanto259 added the enhancement New feature or request label Oct 19, 2022
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanto259 tanto259 merged commit c924f44 into openmainframeproject:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants