Fix rejection threshold check in sample_with_constraints

openmc-dev · May 14, 2024 · ca3ba80 · ca3ba80
1 parent 42898cc
commit ca3ba80
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/source.cpp b/src/source.cpp
@@ -190,6 +190,10 @@ SourceSite Source::sample_with_constraints(uint64_t* seed) const
       }
     }
   }
+
+  // Increment number of accepted samples
+  ++n_accept;
+
   return site;
 }
 

diff --git a/tests/unit_tests/test_source.py b/tests/unit_tests/test_source.py
@@ -127,7 +127,7 @@ def test_constraints_independent(sphere_box_model, run_in_tmpdir):
     model, cell1, cell2, cell3 = sphere_box_model
 
     # Set up a box source with rejection on the spherical cell
-    space = openmc.stats.Box(*cell3.bounding_box)
+    space = openmc.stats.Box((-4., -1., -1.), (4., 1., 1.))
     model.settings.source = openmc.IndependentSource(
         space=space, constraints={'domains': [cell1, cell2]}
     )
-Original file line number
+Diff line change
@@ Expand Up @@
           }
         }
       }
+      // Increment number of accepted samples
+      ++n_accept;
       return site;
     }
@@ Expand Down @@