Adding missing origin to CylindricalMesh.from_domain #2676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While making cylindrical meshes from a domain I noticed the mesh was not fitting the geometry correctly in the Z direction. After digging into the code I noticed that the origin was not set and therefore defaulting to 0,0,0. My geometry starts on the zplane=0 and goes upwards. Anyway this PR now sets the origin to the center of the bounding box.
Fixes # (issue)
Checklist