Refactor of translation from mesh handle to index for DAGMC geometry. #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
reviewed
Sep 13, 2023
paulromano
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I was reviewing #2655, I noticed that we have some convoluted calls in
next_cellfor getting the index of DAGMC volumes and surfaces intomodel::cells/model::surfaces. This PR adds a few methods to clean that up a bit and avoid someone getting lost in logic they shouldn't have to worry about outside of theDAGUniverseclass. Just a refactor, so no additional tests here.Fixes # (issue)
Checklist