Code

Fixed Source Random Ray#2988

Code

Merged

jtramm merged 232 commits intoopenmc-dev:developopenmc-dev/openmc:developfrom jtramm:random_ray_fixed_source6jtramm/openmc:random_ray_fixed_source6Copy head branch name to clipboardJun 17, 2024

+2,120-425

Commits

Commits on Jun 16, 2023

• first commit. File layout, classes, source region init.

  jtramm

  committed
  d76033a

• added source update function

  jtramm

  committed
  c2fa6aa

• added high level control function

  jtramm

  committed
  dc30912

• added cell normalization routine

  jtramm

  committed
  31609b0

• added add source to flux function

  jtramm

  committed
  0e2dcec

• added k-eff update function

  jtramm

  committed
  7db4a7d

• basic iteration code is in.

  jtramm

  committed
  a782fa4

• adding ray methods.

  jtramm

  committed
  785c4d6

• adding more ray methods.

  jtramm

  committed
  2ccc838

• whitespace fixes

  jtramm

  committed
  168ca04

• working on debugging the compile. All basic pieces in place though, sans tallies.

  jtramm

  committed
  2c45008

• continued debugging

  jtramm

  committed
  003c646

• Compile-time bug fixes and refactoring to use particle_data accessors.

  jtramm

  committed
  f232980

• assed basic printout. Results look decent.

  jtramm

  committed
  04e7e12

• removed tallying (besides basic things like k-eff)

  jtramm

  committed
  d66cdbb

• added clean timing/result output function.

  jtramm

  committed
  588f1ce

• added the basics of clean tally-based output

  jtramm

  committed
  442153c

• fixed first tally init issue that was causing seg fault. Getting 0 value tallies now.

  jtramm

  committed
  baf1f5a

• ensured that all active tallies are used, not just analog

  jtramm

  committed
  2c2770b

• generic tally solution working. A little slow

  jtramm

  committed
  e785b26

• added energy integrated version. About 2x fast, but still too slow. Why not pre-compute and store?

  jtramm

  committed
  9566890

• added tally mapper, but now there is a problem where what if we did not hit all the cells before entering the active region?

  jtramm

  committed
  7646594

• Added ability for tally conversion to run multiple times if not all FSRS were hit on the first iteration

  jtramm

  committed
  7b46663

• minor cleanup of tally task conversion code

  jtramm

  committed
  f28d655

• moved tallying and tally conversion functions into separate file

  jtramm

  committed
  2b43008

• added some comments

  jtramm

  committed
  5548628

• moved initialization of tally task array to where other cell-wise arrays are initialized

  jtramm

  committed
  7503eb6

• parallelized flux/volume zeroing routines. Streamlined instability and low FSR hit rate detection and output.

  jtramm

  committed
  1eb5eec

• added more output metrics

  jtramm

  committed
  958a73a

• changed parallelization scheme for normalization routines. Removed target miss rate printout.

  jtramm

  committed
  ec78527

Commits on Oct 3, 2023

• first commit. File layout, classes, source region init.

  jtramm

  committed
  eeda6ab

• added source update function

  jtramm

  committed
  6a6d100

• added high level control function

  jtramm

  committed
  34c35db

• added cell normalization routine

  jtramm

  committed
  e19e3e3

• added add source to flux function

  jtramm

  committed
  68af51e

• added k-eff update function

  jtramm

  committed
  7673afb

• basic iteration code is in.

  jtramm

  committed
  cfab02a

• adding ray methods.

  jtramm

  committed
  f40f807

• adding more ray methods.

  jtramm

  committed
  c373560

• whitespace fixes

  jtramm

  committed
  ebee0ef

• working on debugging the compile. All basic pieces in place though, sans tallies.

  jtramm

  committed
  25f1fcc

• continued debugging

  jtramm

  committed
  aa9b732

• Compile-time bug fixes and refactoring to use particle_data accessors.

  jtramm

  committed
  a3ed5dd

• assed basic printout. Results look decent.

  jtramm

  committed
  e9708d6

• removed tallying (besides basic things like k-eff)

  jtramm

  committed
  8d22e78

• added clean timing/result output function.

  jtramm

  committed
  247e8df

• added the basics of clean tally-based output

  jtramm

  committed
  9610a2d

• fixed first tally init issue that was causing seg fault. Getting 0 value tallies now.

  jtramm

  committed
  84cfdaa

• ensured that all active tallies are used, not just analog

  jtramm

  committed
  d74781e

• generic tally solution working. A little slow

  jtramm

  committed
  68bee19

• added energy integrated version. About 2x fast, but still too slow. Why not pre-compute and store?

  jtramm

  committed
  a3c9804

• added tally mapper, but now there is a problem where what if we did not hit all the cells before entering the active region?

  jtramm

  committed
  0c5200b

• Added ability for tally conversion to run multiple times if not all FSRS were hit on the first iteration

  jtramm

  committed
  4b60bd5

• minor cleanup of tally task conversion code

  jtramm

  committed
  64a6d6e

• moved tallying and tally conversion functions into separate file

  jtramm

  committed
  b1167d9

• added some comments

  jtramm

  committed
  6566cdc

• moved initialization of tally task array to where other cell-wise arrays are initialized

  jtramm

  committed
  738910a

• parallelized flux/volume zeroing routines. Streamlined instability and low FSR hit rate detection and output.

  jtramm

  committed
  1d9254e

• added more output metrics

  jtramm

  committed
  d998d06

• changed parallelization scheme for normalization routines. Removed target miss rate printout.

  jtramm

  committed
  58d516b

• allowed for different cell instances to be given different material types

  jtramm

  committed
  7ffb30d

• fixed fast forward issue

  jtramm

  committed
  5ff2be8

• updated to use zero temp and angle indices when accessing XS data. Added statepoint output.

  jtramm

  committed
  69abd98

Commits on Nov 21, 2023

• used OpenMC init sim

  jtramm

  committed
  2cb971c

• using init and finalize batch

  jtramm

  committed
  504cb54

• using generations now as well

  jtramm

  committed
  a6a00b3

• using integrated keff tally

  jtramm

  committed
  ecc0087

• commented out unneeded init statements

  jtramm

  committed
  f363645

• set weight to 1.0

  jtramm

  committed
  c5fbb4c

• Switched random ray enum check to use a new solver type variable instead of run mode.

  jtramm

  committed
  56e84f7

• removed duplicate timer

  jtramm

  committed
  bbd325d

Commits on Nov 22, 2023

• figured out bug -- was due to actual bug in openmc where it is reverting to CE logic when the group number is 0. It works in MGMC, but is unnecessarily slow.

  jtramm

  committed
  2854d51

• input validation is well along -- maybe complete?

  jtramm

  committed
  8e91d50

• added fixed source checking

  jtramm

  committed
  94705ef

Commits on Nov 28, 2023

• refactor from Ray to RandomRay

  jtramm

  committed
  54f39de

Commits on Nov 29, 2023

• added source validation

  jtramm

  committed
  b3ea0f6

• refactored to use settings/globals directly rather than passing as arguments everywhere

  jtramm

  committed
  2d90cd4

• adding comments, and switched to setting to previous source instead of previous flux in case where FSR has nonzero volume but was not hit this iteration. Appears to improve fidelity considerably fo…

  Show description for 872ff56
  jtramm

  committed
  872ff56

• moved validation code to end of file

  jtramm

  committed
  39cdd66

Commits on Dec 1, 2023

• partial addition of docs and python interface

  jtramm

  committed
  43df38a

• finished up python interface?

  jtramm

  committed
  6cf75a6

• fixed issue with int vs real in python interface, and added check for MPI

  jtramm

  committed
  dad86a0

• partial domain replication. Need to not print double, and need to reduce number of global intersections.

  jtramm

  committed
  f7e0400

Commits on Dec 4, 2023

• fixed issue with tallies in mpi mode. Issue was solely with the cell positions being reduce summed, when something more complex was needed so that valid positions were picked.

  jtramm

  committed
  6eb99bd

• added more comments

  jtramm

  committed
  b4fffb8

• added reduction of intersection counts

  jtramm

  committed
  ed34ab2

• added timer for source reductions, and added warning about slow reduction operations

  jtramm

  committed
  fe4194d

• removed extra comment

  jtramm

  committed
  bec2b82

Commits on Dec 5, 2023

• added lots of comments

  jtramm

  committed
  1fbd373

• fixed comment issue

  jtramm

  committed
  027653b

• removed assert statements and replaced with errors

  jtramm

  committed
  1789d41

• added vtk plotter

  jtramm

  committed
  fefe9aa

• added FSR and material plots, but FSR plot is weird.

  jtramm

  committed
  3bf3134

• FSRs appear much better as floats rather than modulused ints, for some reason.

  jtramm

  committed
  811c399

• simplified plotting routine a bit

  jtramm

  committed
  95ebeed

• parallelized plotter

  jtramm

  committed
  b3a38e0

• using plot.xml inputs for plots

  jtramm

  committed
  00f0e4c

• plotter is using xml input fname

  jtramm

  committed
  4939ceb

• added nice output before plotting, and enforcement of acceptable plotting inputs

  jtramm

  committed
  bce3b70

• only plot if there is a plotting xml file

  jtramm

  committed
  8704ee7

• added storage of accumulated final flux and plotting at the end

  jtramm

  committed
  98f0696

Commits on Dec 6, 2023

• added first try at tolerant testing harness

  jtramm

  committed
  3254e3b

• tweaks to tolerant testing. Report k-eff simulation for k-eff combined when in random ray mode. Addition of first random ray test

  jtramm

  committed
  a7d90df

• added random ray pincell example

  jtramm

  committed
  54d0a71

• removed unneeded headers

  jtramm

  committed
  8a49e5d

• added endianness flipping function, ability to output multiple plots for different views, and ability to ignore non-voxel plots so as to allow them to be in in plots.xml for pure geometry visualiza…

  Show description for 1419f39
  jtramm

  committed
  1419f39

• adjusted comment

  jtramm

  committed
  dd90d63

Commits on Jan 8, 2024

• fixed merge issue

  jtramm

  committed
  1818989

• improved pincell example

  jtramm

  committed
  cf0f69b

• ran git clang-format develop

  jtramm

  committed
  2248ec4

• Added a loop before plotting to change filenames first, so the plot summary filenames display as expected.

  jtramm

  committed
  8216a6c

• ran git clang-format develop

  jtramm

  committed
  735fcfd

Commits on Jan 10, 2024

• updated test to use RectangularPrism instead of rectangular_prism`

  jtramm

  committed
  33c333b

• Revert "fixed fast forward issue"

  Show description for 0b0dc42
  jtramm

  committed
  0b0dc42

• ran clang-format on settings.h

  jtramm

  committed
  12f24f0

• added back in comment

  jtramm

  committed
  69ae4f4

• removed comments/debugging code

  jtramm

  committed
  99a34cc

• ran git clang-format develop

  jtramm

  committed
  a07c534

• Update src/random_ray/iteration.cpp

  Show description for e0b62a7
  

  jtramm

  and

  gridley

  authored
  e0b62a7

Commits on Jan 11, 2024

• incorporation of @gridley review comments

  jtramm

  committed
  63857aa

• Merge branch 'random_ray_merge' of github.com:jtramm/openmc into random_ray_merge

  jtramm

  committed
  57dad69

Commits on Jan 17, 2024

• Merge branch 'develop' of github.com:openmc-dev/openmc into random_ray_merge

  jtramm

  committed
  d3cfd4b

• added random_ray.rst methods file and updated index

  jtramm

  committed
  ead8cfa

Commits on Jan 25, 2024

• fixed over/underbars

  jtramm

  committed
  561d8fa

Commits on Jan 26, 2024

• added random ray user guide

  jtramm

  committed
  bb24326

• added lots more documentation to theory section

  jtramm

  committed
  a060d4e

• added compressed image files to random ray documentation

  jtramm

  committed
  a42e0eb

Commits on Jan 28, 2024

• continued work on docs

  jtramm

  committed
  53d3a5e

• continued work on docs

  jtramm

  committed
  74d7ac7

• continued updated to docs

  jtramm

  committed
  2893ecf

• continued work on docs

  jtramm

  committed
  872bcfe

Commits on Jan 29, 2024

• updating random ray docs

  jtramm

  committed
  32c65d8

• More random ray docs. Fixed equation notation, added more references, etc.

  jtramm

  committed
  66387b4

Commits on Feb 6, 2024

• Added random_ray_source option to IndependentSource to flag source as the one to use for sampling random rays rather than neutrons.

  jtramm

  committed
  2ec33be

• ran git clang-format HEAD~1

  jtramm

  committed
  5c63a31

• Refactored random ray source indicator to use particle type rather than a separate field.

  jtramm

  committed
  4a0500f

• ran git clang-format HEAD~1

  jtramm

  committed
  4727569

• removed the rest of old random_ray_source source field.

  jtramm

  committed
  f20bc1e

• removed unneeded lines throughout

  jtramm

  committed
  98b65d1

• updated docs to account for new random ray source specification interface

  jtramm

  committed
  916b2bd

Commits on Feb 7, 2024

• added accessors for cell material/temperature fields to abstract logic of accessing these fields when distrib materials/temps are used.

  jtramm

  committed
  524f2b4

• ran git clang-format HEAD~1

  jtramm

  committed
  f122ef0

Commits on Feb 12, 2024

• Merge branch 'develop' into random_ray_merge

  jtramm

  committed
  4a92297

• fixed bug in Cell::sqrtkT accessor return type

  jtramm

  committed
  3821eb2

Commits on Feb 13, 2024

• incorporation of review comments

  jtramm

  committed
  00d07dc

• refactor into classes mostly complete. Just some cleanup remaining.

  jtramm

  committed
  14faa19

Commits on Feb 14, 2024

• refactor into classes complete and working (still needs cleanup)

  jtramm

  committed
  5555dd9

• refactor of random ray filenames

  jtramm

  committed
  28942b9

• code cleanup, comments, formatting

  jtramm

  committed
  383bd31

• ran git clang-format develop

  jtramm

  committed
  e3bc76a

• changed include guard names

  jtramm

  committed
  e5cdc3e

• ran git clang-format develop

  jtramm

  committed
  eb66a04

• Basic source application functions

  jtramm

  committed
  2e4b12c

• applied distrbcell instance bugfix

  jtramm

  committed
  9f2ad9c

• fixed source mode calling. Working on kobayashi

  jtramm

  committed
  738e27e

• ran git clang-format develop

  jtramm

  committed
  0173b06

• added fixed source regression tests

  jtramm

  committed
  86a4a88

Commits on Feb 15, 2024

• updated docs

  jtramm

  committed
  a92d35c

• added comment for TolerantPyAPITestHarness class

  jtramm

  committed
  b715f03

• enabled tracklength and collision tallies. Fixed vacuum BC bug where particle type was checked instead of solver mode

  jtramm

  committed
  b4ad777

• updated documents and example to remove the requirement of analog tally estimation

  jtramm

  committed
  2d7eec3

Commits on Feb 16, 2024

• Remove docs for random_ray_source option that was removed from python source object

  jtramm

  authored
  ef0fdca

• added TODO item on inheriting from GeometryState instead of Particle.

  jtramm

  committed
  30d0d1d

• Changed random ray interface on python side.

  jtramm

  committed
  7de305b

• refactor C++ random ray interface to use random_ray object

  jtramm

  committed
  007a935

• updated docs, examples, and tests to use new interface. Also added vacuum BC test.

  jtramm

  committed
  15e6bec

• updated docs

  jtramm

  committed
  591d0e2

• ran git clang-format develop

  jtramm

  committed
  1d8722f

• removed random ray particle type from C++ and python

  jtramm

  committed
  a58be8c

• ran git clang-format develop

  jtramm

  committed
  3d2eab9

• fixed bug with outputting empty random ray dictionary

  jtramm

  committed
  982272c

• simplified docs example slightly

  jtramm

  committed
  43b842d

Commits on Feb 18, 2024

• merged with new UI changes

  jtramm

  committed
  ddb8e4f

• merged with new UI changes

  jtramm

  committed
  047ec26

• finished merging with UI update

  jtramm

  committed
  ace48f9

• updated docs for new UI

  jtramm

  committed
  97751be

• updated tests for new UI. Disabled default source generation in eigenvalue mode. Fixed source validation for new UI

  jtramm

  committed
  720040a

• ran git clang-format develop

  jtramm

  committed
  bf0b84d

• incorporation of @gridley docs review comments

  jtramm

  committed
  4819aaa

Commits on Feb 19, 2024

• fixed bug logic bug in applying sources to material filled cells.

  jtramm

  committed
  208a982

• fixed bug in fixed source assignment due to universe storing index instead of ID

  jtramm

  committed
  04c0ed2

Commits on Mar 5, 2024

• Line spacing in random ray documentation

  paulromano

  committed
  c9c691d

• Small changes in user's guide random ray section

  paulromano

  committed
  03333d2

• Edits in random ray methods docs

  paulromano

  committed
  e8ff8f5

• Small changes and updates

  paulromano

  committed
  0d94bbe

• Fix XML roundtrip of settings.random_ray

  paulromano

  committed
  66b4a3d

Commits on Mar 6, 2024

• incorporation of @promano review comments pt 1

  jtramm

  committed
  06d4343

• changed \vec to \mathbf in random ray docs

  jtramm

  committed
  3c13dd2

• incorporation of @promano review comments pt 2

  jtramm

  committed
  433b000

• changed dV to d\mathbf{r}

  jtramm

  committed
  3f585ef

• incorporation of @promano review comments pt3

  jtramm

  committed
  cb813ce

• incorporation of @promano review comments pt 4

  jtramm

  committed
  fa0b844

• ran git clang-format develop

  jtramm

  committed
  45e3bc9

• updated random ray test expected results due to bug fix with ray termination length truncation

  jtramm

  committed
  de456e0

• removed unneeded vector header

  jtramm

  committed
  936d703

Commits on Mar 22, 2024

• Small fix in random_ray.rst

  paulromano

  committed
  d426075

Commits on Mar 29, 2024

• marked random_ray_tally as const, and removed unneeded prototype

  jtramm

  committed
  efe6353

• updated docs comment

  jtramm

  committed
  581229e

Commits on Apr 3, 2024

• incorporation of @yardasol review comments

  jtramm

  committed
  d60c3c0

Commits on Apr 4, 2024

• Merge branch 'develop' into random_ray_merge

  jtramm

  committed
  93bb5b2

Commits on Apr 16, 2024

• merged with prime random ray branch

  jtramm

  committed
  37acddd

• adjusting output formatting for fixed source random ray

  jtramm

  committed
  11c7c80

• added new tallytask stuff

  jtramm

  committed
  3e0f623

• added more tally updates

  jtramm

  committed
  82127dc

• fixed const issue

  jtramm

  committed
  c0a40a5

• progress on correct flux tally normalization

  jtramm

  committed
  d31a41b

• Flux tally normalization update complete - getting same answer on Kobayashi now.

  jtramm

  committed
  ec8347a

• removed unneeded source strength function

  jtramm

  committed
  38ebe59

• syncing of fixed source application routines with newest branch

  jtramm

  committed
  a8dfdd9

Commits on Apr 30, 2024

• corrected tally volume normalization

  jtramm

  committed
  6d0c6ab

• simplified tally volume normalization

  jtramm

  committed
  f71b818

• merged fixed source with develop

  jtramm

  committed
  4b22d9d

• updating docs

  jtramm

  committed
  c5f0297

• reverted submodule changes

  jtramm

  committed
  6df908b

• cleanup of comments in tally function

  jtramm

  committed
  cbb0141

• improved documentation on hash_combine

  jtramm

  committed
  d81924f

• comment cleanup

  jtramm

  committed
  5a3762b

• updated python regression tests given new tally normalization procedure

  jtramm

  committed
  2d51ff1

Commits on May 31, 2024

• Merge branch 'develop' into random_ray_fixed_source6

  jtramm

  authored
  5550a49

Commits on Jun 3, 2024

• merging with develop

  jtramm

  committed
  feff168

• ran git clang-format develop

  jtramm

  committed
  b9cf141

• ran git clang-format develop with LLVM 15 instead of LLVM 19

  jtramm

  committed
  a52c3fe

Commits on Jun 4, 2024

• updated tests with new source domain format

  jtramm

  committed
  44a6ee4

Commits on Jun 11, 2024

• Small changes from review

  paulromano

  committed
  7622790

• refactor of fixed source variable names to external source names

  jtramm

  committed
  3184e5c

• changed hash_combine to pass by value rather than reference

  jtramm

  committed
  c7c6d3a

• using new constraints/domains API for openmc.IndependentSource

  jtramm

  committed
  94d224f

• ran git clang-format develop

  jtramm

  committed
  924aaca

• ran older version of clang

  jtramm

  committed
  373ca5d

Commits on Jun 12, 2024

• removed comment

  jtramm

  committed
  2ce6736

• Consolidate random ray fixed source tests

  paulromano

  committed
  e1bc0cc

• Change e to E to follow style guidelines

  Show description for 53f5f32
  

  jtramm

  and

  gridley

  authored
  53f5f32