Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wake up the stateMaintainer thread in time when changeToCandidate #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Wake up the stateMaintainer thread in time when changeToCandidate #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0313078
Wake up the stateMaintainer thread in time
BurningCN Jul 1, 2022
959bbf8
Update DLedgerLeaderElector.java
BurningCN Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/io/openmessaging/storage/dledger/DLedgerLeaderElector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public CompletableFuture<HeartBeatResponse> handleHeartBeat(HeartBeatRequest req
//first change to candidate, and notify the state-maintainer thread
changeRoleToCandidate(request.getTerm());
needIncreaseTermImmediately = true;
//TOOD notify
stateMaintainer.wakeup();
return CompletableFuture.completedFuture(new HeartBeatResponse().code(DLedgerResponseCode.TERM_NOT_READY.getCode()));
}
}
Expand Down Expand Up @@ -224,6 +224,7 @@ public CompletableFuture<VoteResponse> handleVote(VoteRequest request, boolean s
//stepped down by larger term
changeRoleToCandidate(request.getTerm());
needIncreaseTermImmediately = true;
stateMaintainer.wakeup();
//only can handleVote when the term is consistent
return CompletableFuture.completedFuture(new VoteResponse(request).term(memberState.currTerm()).voteResult(VoteResponse.RESULT.REJECT_TERM_NOT_READY));
}
Expand Down Expand Up @@ -624,6 +625,7 @@ public CompletableFuture<LeadershipTransferResponse> handleTakeLeadership(
takeLeadershipTask.update(request, response);
changeRoleToCandidate(targetTerm);
needIncreaseTermImmediately = true;
stateMaintainer.wakeup();
return response;
}
}
Expand Down Expand Up @@ -692,15 +694,14 @@ public class StateMaintainer extends ShutdownAbleThread {
public StateMaintainer(String name, Logger logger) {
super(name, logger);
}

@Override
public void doWork() {
try {
if (DLedgerLeaderElector.this.dLedgerConfig.isEnableLeaderElector()) {
DLedgerLeaderElector.this.refreshIntervals(dLedgerConfig);
DLedgerLeaderElector.this.maintainState();
}
sleep(10);
waitForRunning(10);
} catch (Throwable t) {
DLedgerLeaderElector.logger.error("Error in heartbeat", t);
}
Expand Down