Remove scripts for transforming NetCDF to JSON #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aethr
force-pushed
the
remove-json-scripts
branch
2 times, most recently
from
7eea82c to
b41b2a7
Compare
These are no longer necessary after openmethane/openmethane-web#288 introduced the ability to work with NetCDFv4 directly in JavaScript.
This simple test can replace the removed test_domain_json as it tests many of the same things, just without the intermediate step of converting it to JSON.
aethr
force-pushed
the
remove-json-scripts
branch
from
93db7c4 to
98bf5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These scripts were created to output JSON versions of the domain and prior NetCDF files due to the difficulty of working with NetCDFv4 in JavaScript. However, these are no longer necessary after openmethane/openmethane-web#288 is merged.
Checklist
Please confirm that this pull request has done the following:
Notes