Add tests #6
Merged
Add tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: chore: Add ruff to the dev requirements files docs: Pass tests docs: auto generated fixes docs: formatting docs: Notes from the first read through Revert "simplifying to use only the geo_em files not the cro and dot files"
lewisjared
reviewed
May 8, 2024
There was a problem hiding this comment.
Urgh I see what you mean.
In this case, it is fine to wrap download part of the omDownloadInputs.py in a function and then call that function from within a if __name__ == '__main__': block. That will allow you to import omDownloadInputs without triggering the download and follows a pattern that is similar to other scripts in the repo.
That should allow you to not need the temporary_file_for_tests.py
Co-authored-by: Jared Lewis <jared@jared.kiwi.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing the github workflow with this pull request. So it can be ignored for now.