Fix build action #61
Merged
Fix build action #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default shell in ubuntu task runners appears to have changed to dash, so the previous substitution no longer worked.
When building from a version tag (v0.0.0) this should always contain the version, however the metadata-action step sometimes populates this with build-XYZ. This change will always explicitly source the version from pyproject.toml which should always contain a valid semver string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build action in openmethane broke recently due to (I believe) changes in the ubuntu-latest runner which has been updated to a newer version. This PR is porting the same changes that resolved the issue in the openmethane build action.
Checklist
Please confirm that this pull request has done the following:
changelog/Notes