Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on psr/http-message #12

Closed
m-nic opened this issue Jan 29, 2024 · 2 comments · Fixed by #13
Closed

Remove dependency on psr/http-message #12

m-nic opened this issue Jan 29, 2024 · 2 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@m-nic
Copy link
Contributor

m-nic commented Jan 29, 2024

I don't think this package should rely on psr/http-message.
It should be the client responsibility to expose the metrics.
At most some recommendations/examples can be provided.

Most likely many of the clients already use a framework that uses the psr7, meaning they should just hook it up themselves - also this can bring in conflicts for frameworks using psr/http-message: ^2.0 dependency.

Or as in my case, I have to bring in an unwanted dependency because I just want to dump the metrics directly to a file.

What do you think?

@hollodotme hollodotme self-assigned this Feb 22, 2024
@hollodotme hollodotme added the enhancement New feature or request label Feb 22, 2024
@hollodotme
Copy link
Member

I'm always in for reduction of dependencies. I'll have a look, if we can leave it out.

@hollodotme hollodotme added this to the v0.4.0 milestone May 4, 2024
hollodotme added a commit that referenced this issue May 4, 2024
…ependency to psr/http-message, #12

* Remove tests
* Update examples
@hollodotme
Copy link
Member

@m-nic I agree with you and removed the classes HttpResponse and OutputStream which implemented psr/http-message interfaces. Thus removed the composer dependency as well.

Will be released in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants