Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signatures for compatibility with php8. Update composer.json p… #11

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

m-nic
Copy link
Contributor

@m-nic m-nic commented Jan 29, 2024

…hp dependency. Add php 8 Dockerfile. Add compatibility for tests.

Fixes #<issue-number>

Proposed Changes

Further comments

@m-nic m-nic mentioned this pull request Jan 29, 2024
@hollodotme hollodotme changed the base branch from master to development January 30, 2024 09:02
Copy link
Member

@hollodotme hollodotme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Thank you!

I'll merge it to development branch, as I want to change 2 small things before releasing.

@hollodotme hollodotme merged commit 3e1dda5 into openmetrics-php:development Jan 30, 2024
@m-nic
Copy link
Contributor Author

m-nic commented Jan 30, 2024

Cool, waiting for it to be released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants