Remove space between labels #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to spec labels are separated by a comma, without any whitespace. To show this behavior we changed the integration test to have one case with 2 labels. This makes the integrationtest fail. We are using the `withLabels` method twice because their is an incompatibility between php 7.3 and 7.4 vardict arguments are different ordered between those versions. By calling the method twice we can make sure the order is kept.
|
@jaapio Thanks for spotting this. 💪 It's not that obvious in the spec. I'll merge it and release v0.4.1. |
|
✅ v0.4.1 was released. |
|
Thanks for merging and releasing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec labels are separated by a comma, without any whitespace. To show this behavior we changed the integration test to have one case with 2 labels. This makes the integrationtest fail.
We are using the
withLabelsmethod twice because their is an incompatibility between php 7.3 and 7.4 vardict arguments are different ordered between those versions. By calling the method twice we can make sure the order is kept.