Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions #1128

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Predictions #1128

merged 2 commits into from
Apr 19, 2022

Conversation

PGijsbers
Copy link
Collaborator

Reference Issue

Closes #1103

What does this PR implement/fix? Explain your changes.

Adds a predictions property to the OpenMLRun object which will download and format the predictions on-demand.
Only output for a pandas dataframe is supported, since we will slowly move to that standard anyway.
Local run results can also be formatted in this way.
Data is only accessed and transformed when the property is called and does not impact performance otherwise.

How should this PR be tested?

I added a line to test where we test other run consistency (download vs local run).

Any other comments?

Test server is currently not live so I couldn't test on the whole suite, but since it's an added feature it shouldn't interfere with old tests. I did a test on the live server which worked, but it may not be as comprehensive.

@PGijsbers PGijsbers requested a review from mfeurer March 11, 2022 15:22
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do you know whether the server is already back up?

@PGijsbers
Copy link
Collaborator Author

As far as I am aware the test server is running but not yet populated with the usual test data...

@mfeurer
Copy link
Collaborator

mfeurer commented Apr 19, 2022

I see. Then I guess we're good to merge this :)

@PGijsbers PGijsbers merged commit 99a62f6 into develop Apr 19, 2022
@PGijsbers PGijsbers deleted the predictions branch April 19, 2022 18:28
PGijsbers added a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
* Add easy way to retrieve run predictions

* Log addition of ``predictions`` (openml#1103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make predictions from a run easily accessible
2 participants