Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store predictions_url in runs #783

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Conversation

amueller
Copy link
Contributor

Store predictions_url from xml in runs object when getting run from server.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #783 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #783      +/-   ##
===========================================
+ Coverage    87.71%   87.72%   +<.01%     
===========================================
  Files           36       36              
  Lines         4177     4187      +10     
===========================================
+ Hits          3664     3673       +9     
- Misses         513      514       +1
Impacted Files Coverage Δ
openml/runs/functions.py 82.22% <100%> (+0.14%) ⬆️
openml/_api_calls.py 83.11% <0%> (-1.3%) ⬇️
openml/extensions/extension_interface.py 91.17% <0%> (ø) ⬆️
openml/extensions/sklearn/extension.py 91.27% <0%> (+0.03%) ⬆️
openml/flows/functions.py 87.74% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc1638...bd0ae14. Read the comment docs.

@mfeurer mfeurer merged commit dcac17e into openml:develop Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants