Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(usage): link to gallery and removed TODO text #954

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

scratchmex
Copy link
Contributor

@scratchmex scratchmex commented Oct 1, 2020

Reference Issue

Fixes #952.

What does this PR implement/fix? Explain your changes.

Link to gallery and removed the TODO tag from non-written tutorials

How should this PR be tested?

--

Any other comments?

@scratchmex scratchmex changed the title doc(usage): link to gallery and removed TODO text docs(usage): link to gallery and removed TODO text Oct 1, 2020
@PGijsbers
Copy link
Collaborator

Thanks! One clarification, we think the "advanced topics" section can be removed altogether as the "todo list" is now in the Github issue tracker.

I noticed that the "filter and explore datasets" link under the "Datasets" header on the page is broken. Could you link to the "examples/30_extended/datasets_tutorial.html" dataset example from there?

If you could make those two changes the page will be all up to date and I'd be happy to merge 👍

@scratchmex
Copy link
Contributor Author

What about now?

@PGijsbers
Copy link
Collaborator

Looks good 🎉 Thank you for the contribution!

@PGijsbers PGijsbers merged commit 5641828 into openml:develop Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Github issues for Advanced Topics documentation
2 participants