-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNPOps 0.6 #107
Comments
@RaulPPelaez any change to finish #105? |
Does anybody want to implement/finish something more? Ping: @peastman |
It defeated me tbh. I do not think it is worth stopping the release for it. I will give it another spin. |
The test on the GPU don't pass: https://github.com/openmm/NNPOps/actions/runs/5645655178 |
I think both failures could be attributed to the inaccuracy introduced by the non-deterministic order of operations in the CUDA versions. |
Sounds good to me. |
Do we want to update the tests to make them less strict? |
Maybe this is enough? |
Both tests pass locally in a 4090 at the current master 5e2438d , perhaps the CI was just a fluke? assert energy_error < 5e-7
if molFile == '3o99':
assert grad_error < 0.05 # Some numerical instability
else:
> assert grad_error < 5e-3
E AssertionError: assert tensor(0.0071, device='cuda:0') < 0.005 I do not think this is due to a bug, I would blame whatever kernel torch uses for sm_75 being a tad more inaccurate. |
Okay so now that #108 is merged are we ready for a new release? There have been some breaking but very good changes in conda-forge packaging for CUDA conda-forge/conda-forge.github.io#1963 so it might take a bit to get that sorted. I will get the release on conda-forge started, but will wait to actually merge it in until we decide if the release is ready. |
The changes should not affect CUDA<12 builds, right? |
OK! I'm making the release |
We have a release: https://github.com/openmm/NNPOps/releases/tag/v0.6 |
@mikemhenry you can proceed with conda-forge/nnpops-feedstock#24. If CUDA 12 is an issue, we can build just for CUDA 11. And then sort out CUDA 12. |
NNPOps 0.6 is out! @jchodera could you make a tweet (or whatever is it called now)? |
Let's start the new release.
New features:
Testing improvements:
The text was updated successfully, but these errors were encountered: