-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Self-Hosted AWS GPU Runner #100
Conversation
Ready for review @RaulPPelaez and @raimis I only tested the latest version and before we merge this in we will want to decide how often to run the scheduled test and we want to remove the part the triggers the run in this branch. |
Also one more thing I want to do before merge is to use variables for the package versions so it is easier to change in the future |
This is a really cool functionality @mikemhenry, thanks! Its just some minor comments from me. |
Okay this is ready for review @raimis and @RaulPPelaez |
If we want to keep the cost down, running it only on merge commits to master is probably sufficient. Running it nightly on code that's already been merged and tested doesn't tell us much more. |
I agree with @peastman, nightly is too much. I say we run this just before committing to master. |
Okay! This should be good to merge now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. I say lets merge.
BTW, I see this is suffering from #98
Do you have any explanation?
I have not been able to reproduce it. My guess is on some CMake parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
No description provided.