Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the selection of the activation function in CFConv #67

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix the selection of the activation function in CFConv #67

merged 1 commit into from
Aug 22, 2022

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Aug 18, 2022 •
edited
Loading

NNPOps.CFConv used the shifted soft plus activation function regardless the value of the activation argument.

  • Fix the selection of the activation function

Fixes #66

@raimis raimis self-assigned this Aug 18, 2022
@raimis raimis marked this pull request as ready for review August 18, 2022 15:09
@raimis raimis marked this pull request as draft August 18, 2022 15:09
@raimis raimis marked this pull request as ready for review August 19, 2022 07:19
@raimis raimis requested a review from peastman August 19, 2022 07:19
@raimis
Copy link
Contributor Author

raimis commented Aug 19, 2022

@peastman could you review?

peastman
peastman approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@raimis raimis merged commit ee33842 into openmm:master Aug 22, 2022
@raimis raimis mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peastman peastman peastman approved these changes

Assignees

@raimis raimis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the warnings of CFConv
2 participants
@raimis @peastman