Improve the build system to use find_package(Python) instead of find_package(PythonLibs) #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
raimis
changed the title
|
Rename to make a release log clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling find_package with Python and then PythonLibs was finding the python exec from conda but the libs and includes in my system, which was causing all kinds of weird errors.
find_package(PythonLibs) was deprecated in CMake 3.12, find_package(Python) supersedes it. The current CMakeLists requires 3.20.
I modified CMakeLists.txt to only use find_package(Python) for the exec and the development libraries.