Move all torch.ops.load calls to the __init__.py scripts #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RaulPPelaez is this ready for review? |
|
Yes, thanks. |
raimis
reviewed
Mar 8, 2023
|
My last commit broke the tests. This made me notice there is something weird about make install. See its output: Install the project...
-- Install configuration: ""
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/libNNPOpsPyTorch.so
-- Set runtime path of "/usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/libNNPOpsPyTorch.so" to ""
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/__init__.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/BatchedNN.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/CFConv.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/CFConvNeighbors.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/EnergyShifter.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/OptimizedTorchANI.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/SpeciesConverter.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/SymmetryFunctions.py
-- Up-to-date: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/__init__.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/getNeighborPairs.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/neighbors/__init__.py
-- Installing: /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/neighbors/getNeighborPairs.pyThe second time init.py is mentioned it says "up to date", and in fact $ diff /usr/share/miniconda3/envs/nnpops/lib/python3.8/site-packages/NNPOps/{neighbors,}/__init__.pyPrints nothing, i.e NNPOps/neighbors/init.py overwrites NNPOps/init.py |
|
Remove Lines 80 to 81 in 293d908 |
raimis
reviewed
Mar 9, 2023
|
This is ready for review. |
raimis
reviewed
Mar 14, 2023
|
@peastman any comments? Otherwise, we can merge. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #68 by moving all calls to torch.ops.load to the init.py scripts.