-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify designated_period_except definition #136
base: dev
Are you sure you want to change the base?
Conversation
Can your teams take a look at this rewording @jacobmalleau @pierre-bouffort @jiffyclub and make sure that this change does not require anyone to redo their existing code, and that it's not breaking? |
Hello @schnuerle and thanks for pointing it out. |
Looks good to me. |
It also seems fine to me - this is a welcome addition to the spec. |
This does now mean that the |
Co-authored-by: Matt Davis <jiffyclub@gmail.com>
You may be right here. If we do rename this field then it will have to wait for a 2.0 major release instead of a 1.1.0 patch. Is there some way to clarify this in the field description instead for now? |
@LaurentG-AMD
Policy A allows parking 9h00-11h00 on Fridays, April 1st to November 30th, but not during snow removal. Policy B prohibits parking at all times. Since Policy A has a lower priority it would take precedence over B during the Friday 9-11 timespan. Also, are you still interested in exceptions to user classes? Maybe we could add it to this PR. |
name: Mitch Vars
title: Clarify designated_period_except definition
CDS Pull Request
Explain pull request
The current definition of
designated_period_except
is unclear in that it only covers values named indesignated_period
. This PR expands the definition to cover all fields in the Time Span. For example, Ifdays_of_week
is['sun']
, the Time Span does not apply on Sundays.Additional info in #117
Is this a breaking change
Impacted Spec
Which API(s) will this pull request impact?
Curbs