-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple modes (255 redux) #336
Conversation
I know back on the 5/23 call (at least as documented in the comments on #255) the idea of outputting all schemas into the root of Especially in light of @jfh01 comments from a prior (4/4) call and some of what we started talking about related to #281 around a hierarchical API - without knowing more on the OpenAPI side, my feeling is sub-directories would allow for better organization and clearer lines of separation. |
@thekaveman When you say "sub-directory approach", do you mean an approach like this PR but outputting the schemas into a mode-specific subdirectory? Or do you mean more like #255 where both the schemas and READMEs are duplicated between modes? |
Exactly! So instead of e.g. |
That sounds good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #170 ! |
Working on enhancing this for 2.0 with #574 |
Explain pull request
This PR clarifies that the current provider endpoints and JSON schema are dockless bike/scooter share only. It is a redux of #255 based on everybody's suggestions.
Is this a breaking change
Provider
oragency
Which API(s) will this pull request impact:
provider
Additional context
Add any other context or screenshots about the feature request here.