Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple modes (255 redux) #336

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Support for multiple modes (255 redux) #336

merged 2 commits into from
Jul 11, 2019

Conversation

hunterowens
Copy link
Collaborator

Explain pull request

This PR clarifies that the current provider endpoints and JSON schema are dockless bike/scooter share only. It is a redux of #255 based on everybody's suggestions.

Is this a breaking change

  • Yes, breaking - we move the JSON Schema.

Provider or agency

Which API(s) will this pull request impact:

  • provider

Additional context

Add any other context or screenshots about the feature request here.

@hunterowens hunterowens requested review from thekaveman and a team as code owners July 11, 2019 00:00
@thekaveman
Copy link
Collaborator

I know back on the 5/23 call (at least as documented in the comments on #255) the idea of outputting all schemas into the root of /provider was decided upon. I can't remember all the details of that conversation (I recall that I may have even been apathetic to the choice). But seeing the changes in-situ and thinking about it more, the sub-directory approach seems like it might make more sense.

Especially in light of @jfh01 comments from a prior (4/4) call and some of what we started talking about related to #281 around a hierarchical API - without knowing more on the OpenAPI side, my feeling is sub-directories would allow for better organization and clearer lines of separation.

@rf-
Copy link
Contributor

rf- commented Jul 11, 2019

@thekaveman When you say "sub-directory approach", do you mean an approach like this PR but outputting the schemas into a mode-specific subdirectory? Or do you mean more like #255 where both the schemas and READMEs are duplicated between modes?

@thekaveman
Copy link
Collaborator

@rf-

an approach like this PR but outputting the schemas into a mode-specific subdirectory

Exactly! So instead of e.g. /provider/dockless_trips.json we have /provider/dockless/trips.json

@rf-
Copy link
Contributor

rf- commented Jul 11, 2019

That sounds good to me 👍

Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hunterowens
Copy link
Collaborator Author

Fixes #170 !

@schnuerle
Copy link
Member

Working on enhancing this for 2.0 with #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants