-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Cleaned Up Policy API #382
Conversation
Incorporate Blue feedback
last minute trims
…ion into dev # Conflicts: # policy/README.md
* Add optional event_type specification to rule statuses * Add JSONSchema Draft 7 for Geography and Policy endpoints/types.
Update markdown so it renders a table properly
pinging @antrim |
I think that the changes needed for schema generation should be pretty simple, because for |
all JSON Schemas need to be generated by running the script in In the interest of getting this merged, I'd like the JSON schemas to follow in 0.4.1, I've removed them from the Spec in this PR and create a new issue for that. |
* remove all references to 'under development', 'alpha', 'feedback requested', etc. * streamline, combine, and re-order content under relevant subsections * normalize payload wrapper format with Provider * normalize endpoint specification format with Provider * additional clarity on some data types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few cleanups of the language and overall content structure, and did my best not to change any of the intent or data structure. A summary of my edits:
- remove all references to 'under development', 'alpha', 'feedback requested', etc.
- streamline, combine, and re-order content under relevant subsections
- normalize payload wrapper format with Provider
- normalize endpoint specification format with Provider
- additional clarity on some data types
Looks great @thekaveman, thanks for those improvements! |
"geographies": [ | ||
"12b3fcf5-22af-4b0d-a169-ac7ac903d3b9" | ||
], | ||
"statuses": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"statuses": [ | |
"statuses": { | |
"unavailable": [], | |
"trip": [] | |
}, |
Explain pull request
Since the #322 has changed so much, here is a new working PR with a number of edits on my account.
Before merge, still needs to fix
Is this a breaking change
Additional context
If I haven't addressed your question about #322, please LMK