-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Properly set app shell public path #1039
Conversation
Size Change: -398 kB (-10.17%) 👏 Total Size: 3.51 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ibacher.
@ibacher fonts are failing to load on dev3. Looks like |
Yeah, I'm aware. This was on the docket to be reverted until I can figure that out. |
Did the revert do the trick? |
Seems like a mixed bag... |
Back working for me now |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This just sets the Webpack public path correctly in the app shell. This should ensure that fonts, etc. are always loaded correctly.
Screenshots
Related Issue
Other