(feat) O3-3857: Support extension overrides in per-slot extension config #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const newState = typeof partial === 'function' ? partial(state.configs.slotName[extensionId]) : partial; | ||
| if (replace) { | ||
| state.configs[slotName][extensionId] = Object.assign({}, newState) as ConfigStore; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| if (replace) { | ||
| state.configs[slotName][extensionId] = Object.assign({}, newState) as ConfigStore; | ||
| } else { | ||
| state.configs[slotName][extensionId] = Object.assign({}, state.configs[slotName][extensionId], newState); |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
|
Size Change: -80.5 kB (-1.42%) Total Size: 5.57 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
Aug 23, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
The "Translation overrides" configuration stuff only works when defined at the app level because the translation namespace does not communicate any extension-specific information.
This PR fixes that so that you can provide translation overrides at the level of specific extensions-in-slots, which is useful for some of the implementation of "Clinical views" and other scenarios using "generic extension components".
Screenshots
With this configuration:
When showing the extension in the slot, we get:
When showing it in a different slot we get:
Related Issue
https://issues.openmrs.org/browse/O3-3857
Other
This uses
___as a field demarcator since other characters I thought of either have special handling in module names or in i18next itself.