-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Workspace title must translate in the workspace container #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
force-pushed
the
fix/e2e-workspace
branch
from
September 5, 2024 16:05
8ccb846
to
10e8dee
Compare
Size Change: -84.8 kB (-1.46%) Total Size: 5.72 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
denniskigen
changed the title
(fix): Workspace title must translate in the workspace container
(fix) Workspace title must translate in the workspace container
Sep 5, 2024
This was referenced Sep 6, 2024
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Fix workspace title translation issue
This PR addresses a timing-related translation bug where workspace titles weren't properly localized when rendered before their corresponding i18next namespace resources were loaded.
Key Changes
useTranslation
hook, which ensures that the resources are loaded properly.Impact
This will fix the failing E2E tests inside the patient chart repository since the workspace titles were not loading properly and the tests were failing with timeouts looking for the correct translation strings.
Screenshots
None
Related Issue
None
Other