Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ to docs #311

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Add FAQ to docs #311

merged 1 commit into from
Feb 8, 2022

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests, or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Adds a FAQ section to the docs.

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @brandones!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

File size impact

Merging doc-faq into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 341 kB (0 B / +0%) 👻
Total (5) 341 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (no impact)
Files new size
Unmodified (17) 1.6 MB (0 B / +0%) 👻
Total (17) 1.6 MB (0 B / +0%) 👻
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (28) 1.92 MB (0 B / +0%) 👻
Total (28) 1.92 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (no impact)
Files new size
Unmodified (23) 2.39 MB (0 B / +0%) 👻
Total (23) 2.39 MB (0 B / +0%) 👻
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.05 MB (0 B / +0%) 👻
Total (18) 2.05 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (no impact)
Files new size
Unmodified (4) 1.73 MB (0 B / +0%) 👻
Total (4) 1.73 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1813696431 on 0a9ecc0

@dkayiwa
Copy link
Member

dkayiwa commented Feb 8, 2022

@brandones this is very useful 👍

@brandones brandones merged commit 4e03b2b into master Feb 8, 2022
@brandones brandones deleted the doc-faq branch February 8, 2022 19:24
@brandones brandones mentioned this pull request Feb 11, 2022
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants