-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-908 - Combine meta and index #324
Conversation
…ture/offline-on-demand
…into feature/offline-on-demand
…into feature/offline-on-demand
…s-esm-core into feature/offline-on-demand
…ture/offline-on-demand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
File size impactMerging feature/offline-on-demand into master impact files as follow: @openmrs/esm-devtools-app (+0.39%)
@openmrs/esm-implementer-tools-app (+0.21%)
@openmrs/esm-login-app (+0.22%)
@openmrs/esm-offline-tools-app (+6.81%)
@openmrs/esm-primary-navigation-app (+0.18%)
@openmrs/esm-app-shell (+0.1%)
|
Error: Error while trying to collect info after merging feature/offline-on-demand into master. Error: Command failed: npx lerna run build lerna notice cli v3.22.1 lerna info ci enabled lerna info Executing command in 19 packages: "yarn run build" lerna info run Ran npm script 'build' in '@openmrs/esm-state' in 12.3s: lerna info run Ran npm script 'build' in '@openmrs/esm-globals' in 12.7s: lerna info run Ran npm script 'build' in '@openmrs/esm-utils' in 14.3s: lerna info run Ran npm script 'build' in '@openmrs/esm-breadcrumbs' in 14.2s: lerna info run Ran npm script 'build' in '@openmrs/esm-error-handling' in 12.9s: lerna info run Ran npm script 'build' in '@openmrs/esm-config' in 14.3s: lerna info run Ran npm script 'build' in '@openmrs/esm-api' in 10.7s: lerna info run Ran npm script 'build' in '@openmrs/esm-extensions' in 10.2s: lerna info run Ran npm script 'build' in '@openmrs/esm-react-utils' in 15.9s: lerna info run Ran npm script 'build' in '@openmrs/esm-styleguide' in 133.0s: lerna info run Ran npm script 'build' in '@openmrs/esm-offline' in 11.4s: lerna info run Ran npm script 'build' in '@openmrs/esm-framework' in 18.7s: lerna ERR! yarn run build exited 2 in '@openmrs/esm-implementer-tools-app' lerna ERR! yarn run build stdout: yarn run v1.22.17 $ webpack --mode=production info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. lerna ERR! yarn run build stderr: [webpack-cli] �[31mFailed to load '/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/apps/esm-implementer-tools-app/webpack.config.js' config�[39m [webpack-cli] �[31mError: Cannot find module './dist/utils/optimize' Require stack: - /home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/tooling/openmrs/default-webpack-config.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/apps/esm-implementer-tools-app/webpack.config.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/webpack-cli.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/bootstrap.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/bin/cli.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@storybook/core/node_modules/webpack/bin/webpack.js at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15) at Function.Module._load (node:internal/modules/cjs/loader:778:27) at Module.require (node:internal/modules/cjs/loader:1005:19) at require (node:internal/modules/cjs/helpers:94:18) at Object. (/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/tooling/openmrs/default-webpack-config.js:8:29) at Module._compile (node:internal/modules/cjs/loader:1101:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Module.require (node:internal/modules/cjs/loader:1005:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/tooling/openmrs/default-webpack-config.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/apps/esm-implementer-tools-app/webpack.config.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/webpack-cli.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/bootstrap.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/bin/cli.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@storybook/core/node_modules/webpack/bin/webpack.js' ] }�[39m error Command failed with exit code 2. lerna ERR! yarn run build exited 2 in '@openmrs/esm-implementer-tools-app' lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately. at ChildProcess.exithandler (node:child_process:397:12) at ChildProcess.emit (node:events:394:28) at maybeClose (node:internal/child_process:1067:16) at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5) Generated by @jsenv/file-size-impact during Report bundle size#1830485067 on 91bdbc6 |
Error: Error while trying to collect info after merging feature/offline-on-demand into master. Error: Command failed: npx lerna run build lerna notice cli v3.22.1 lerna info ci enabled lerna info Executing command in 19 packages: "yarn run build" lerna WARN ECYCLE Dependency cycles detected, you should fix these! lerna WARN ECYCLE @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app lerna WARN ECYCLE @openmrs/esm-implementer-tools-app -> (nested cycle: @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app) -> @openmrs/esm-implementer-tools-app lerna WARN ECYCLE @openmrs/esm-login-app -> (nested cycle: @openmrs/esm-implementer-tools-app -> (nested cycle: @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app) -> @openmrs/esm-implementer-tools-app) -> @openmrs/esm-login-app lerna WARN ECYCLE @openmrs/esm-offline-tools-app -> (nested cycle: @openmrs/esm-login-app -> (nested cycle: @openmrs/esm-implementer-tools-app -> (nested cycle: @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app) -> @openmrs/esm-implementer-tools-app) -> @openmrs/esm-login-app) -> @openmrs/esm-offline-tools-app lerna WARN ECYCLE @openmrs/esm-primary-navigation-app -> (nested cycle: @openmrs/esm-offline-tools-app -> (nested cycle: @openmrs/esm-login-app -> (nested cycle: @openmrs/esm-implementer-tools-app -> (nested cycle: @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app) -> @openmrs/esm-implementer-tools-app) -> @openmrs/esm-login-app) -> @openmrs/esm-offline-tools-app) -> @openmrs/esm-primary-navigation-app lerna WARN ECYCLE (nested cycle: @openmrs/esm-primary-navigation-app -> (nested cycle: @openmrs/esm-offline-tools-app -> (nested cycle: @openmrs/esm-login-app -> (nested cycle: @openmrs/esm-implementer-tools-app -> (nested cycle: @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app) -> @openmrs/esm-implementer-tools-app) -> @openmrs/esm-login-app) -> @openmrs/esm-offline-tools-app) -> @openmrs/esm-primary-navigation-app) -> (nested cycle: @openmrs/esm-primary-navigation-app -> (nested cycle: @openmrs/esm-offline-tools-app -> (nested cycle: @openmrs/esm-login-app -> (nested cycle: @openmrs/esm-implementer-tools-app -> (nested cycle: @openmrs/esm-devtools-app -> openmrs -> @openmrs/esm-app-shell -> @openmrs/esm-devtools-app) -> @openmrs/esm-implementer-tools-app) -> @openmrs/esm-login-app) -> @openmrs/esm-offline-tools-app) -> @openmrs/esm-primary-navigation-app) lerna info run Ran npm script 'build' in '@openmrs/esm-state' in 9.0s: lerna info run Ran npm script 'build' in '@openmrs/esm-globals' in 9.2s: lerna info run Ran npm script 'build' in '@openmrs/esm-utils' in 10.3s: lerna info run Ran npm script 'build' in '@openmrs/esm-breadcrumbs' in 10.8s: lerna info run Ran npm script 'build' in '@openmrs/esm-error-handling' in 10.2s: lerna info run Ran npm script 'build' in '@openmrs/esm-config' in 10.9s: lerna info run Ran npm script 'build' in '@openmrs/esm-api' in 7.9s: lerna info run Ran npm script 'build' in '@openmrs/esm-extensions' in 7.3s: lerna info run Ran npm script 'build' in '@openmrs/esm-react-utils' in 12.0s: lerna info run Ran npm script 'build' in '@openmrs/esm-styleguide' in 93.2s: lerna info run Ran npm script 'build' in '@openmrs/esm-offline' in 8.2s: lerna info run Ran npm script 'build' in '@openmrs/esm-framework' in 13.9s: lerna ERR! yarn run build exited 2 in '@openmrs/esm-primary-navigation-app' lerna ERR! yarn run build stdout: yarn run v1.22.17 $ webpack --mode=production info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. lerna ERR! yarn run build stderr: [webpack-cli] �[31mFailed to load '/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/apps/esm-primary-navigation-app/webpack.config.js' config�[39m [webpack-cli] �[31mError: Cannot find module './dist/utils/optimize' Require stack: - /home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/tooling/openmrs/default-webpack-config.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/apps/esm-primary-navigation-app/webpack.config.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/webpack-cli.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/bootstrap.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/bin/cli.js - /home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@storybook/core/node_modules/webpack/bin/webpack.js at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15) at Function.Module._load (node:internal/modules/cjs/loader:778:27) at Module.require (node:internal/modules/cjs/loader:1005:19) at require (node:internal/modules/cjs/helpers:94:18) at Object. (/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/tooling/openmrs/default-webpack-config.js:8:29) at Module._compile (node:internal/modules/cjs/loader:1101:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Module.require (node:internal/modules/cjs/loader:1005:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/tooling/openmrs/default-webpack-config.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/packages/apps/esm-primary-navigation-app/webpack.config.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/webpack-cli.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/lib/bootstrap.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/webpack-cli/bin/cli.js', '/home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@storybook/core/node_modules/webpack/bin/webpack.js' ] }�[39m error Command failed with exit code 2. lerna ERR! yarn run build exited 2 in '@openmrs/esm-primary-navigation-app' lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately. at ChildProcess.exithandler (node:child_process:397:12) at ChildProcess.emit (node:events:394:28) at maybeClose (node:internal/child_process:1067:16) at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5) Generated by @jsenv/file-size-impact during Report bundle size#1830524681 on 8b26912 |
Looks great, thanks for this! |
Requirements
For changes to apps
If applicable
Summary
Contains a fix for O3-1022 and introduces the optimized bundle asset that merges in the entry module and additionally the bundle manifest. This provides the basis for the renewed offline mode with opt-in functionality.
The PR also contains the button that enables this functionality. The actual opt-in functionality is, however, not yet implemented (subsequent PR).
Screenshots
Related Issue
Other
Nothing.